OCPCLOUD-492: Leader election for machineSets, nodelink, vsphere and healthchecks #571
Conversation
|
/retest |
Danil-Grigorev
force-pushed
the
leader-election
branch
from
247fa79 to
e194757
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Danil-Grigorev
force-pushed
the
leader-election
branch
from
e194757 to
5c9c50e
Compare
Danil-Grigorev
force-pushed
the
leader-election
branch
from
5c9c50e to
646b31c
Compare
|
can we have a separate commit for each controller? |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold missing changes for machineSet |
openshift-ci-robot
added
the
do-not-merge/hold
Danil-Grigorev
force-pushed
the
leader-election
branch
from
646b31c to
46e7216
Compare
|
@Danil-Grigorev thanks for changing the commits, that makes reviewing dramatically easier. |
Danil-Grigorev
force-pushed
the
leader-election
branch
from
46e7216 to
5775423
Compare
|
@enxebre Feel free to LGTM |
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
@Danil-Grigorev can we please also include the PR desc in the commit message 7ea5a32 |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Using leader election by default will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge. Relevant provider PRs: - openshift/cluster-api-provider-gcp#85 - openshift/cluster-api-provider-aws#315 - openshift/cluster-api-provider-azure#122 - openshift/cluster-api-provider-openstack#108 - openshift/cluster-api-provider-baremetal#81 - openshift/cluster-api-provider-ovirt#55 - openshift#571
Danil-Grigorev
force-pushed
the
leader-election
branch
from
7ea5a32 to
f0929b9
Compare
|
/lgtm |
openshift-ci-robot
added
lgtm
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Danil-Grigorev: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre @Danil-Grigorev Why was this merged without the dependent cluster-api providers PR's all being merged in the description? This broke baremetal. Also, why wasn't e2e-metal-ipi run here? It's an optional job, but it should be run on anything that affects us. If it's not going to get run before merging things like this, then maybe we need to enable it to run all the time. |
|
sorry about that @stbenjam, I certainly thought the baremetal PR was merged. Please feel free to make that to job run on every PR while being not blocking. |
This adds integration with: openshift/machine-api-operator#571
This adds integration with: openshift/machine-api-operator#571
This adds integration with: openshift/machine-api-operator#571
This adds integration with: openshift/machine-api-operator#571 Adding 3 new cli arguments for configuring leader elections: -leader-elect -leader-elect-lease-duration int -leader-elect-resource-namespace string Using leader election will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.
Using leader election by default will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge. Relevant provider PRs: - openshift/cluster-api-provider-gcp#85 - openshift/cluster-api-provider-aws#315 - openshift/cluster-api-provider-azure#122 - openshift/cluster-api-provider-openstack#108 - openshift/cluster-api-provider-baremetal#81 - openshift/cluster-api-provider-ovirt#55 - openshift#571
This adds integration with: openshift/machine-api-operator#571 Adding 3 new cli arguments for configuring leader elections: -leader-elect -leader-elect-lease-duration int -leader-elect-resource-namespace string Using leader election will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge. (cherry picked from commit 5ccc992)
7 participants
Added leader election support for all outstanding controllers in MAO .
Using leader election will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.
Relevant provider PRs: